Add TypeScript typing for RejectionHandler #1842
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glensc
force-pushed
the
ts-RejectionHandler
branch
from
06edcda
to
158f152
Compare
|
Any chance this is getting merged soon and released soon? |
|
This project seems dead (read: feature complete and no longer maintained) |
|
@glensc Whom can we CC to get this reviewed and merged? |
|
@halfalicious sorry, I'm not affiliated with this project. |
|
@indexzero Could you take a look at this please ? |
fearphage
approved these changes
Jan 11, 2022
|
I think #1929 is a slightly better version of this, so I am going to close this PR, but hopefully we can merge the other one. Please post over there if you spot anything that that PR is missing. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking if I could monkey patch #1824 without waiting for a release that includes the memory leak fix.
#1462 added handleRejections and winstonjs/winston-transport#41 added handleRejections option
but the TypeScript typing is missing, this PR compensates this.
Fixes #1928