Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DailyRotateFile transport uses local time zone for rotation #456

Closed
intraz opened this issue Sep 22, 2014 · 2 comments
Closed

DailyRotateFile transport uses local time zone for rotation #456

intraz opened this issue Sep 22, 2014 · 2 comments

Comments

@intraz
Copy link

intraz commented Sep 22, 2014

The DailyRotateFile transport rotates based on the local time zone configured on the machine it is running on.
Winston's default time stamps in the log lines are UTC (ISO string).

This means that when the local machine is set to a time zone other than UTC the log file for a given date (as set by DailyRotateFile) might include entries that seem to be from a day before or after (depending on the time zone) when actually they are just described in a different time zone (UTC).

Ideally it (and all other transports) should use the same mechanism used by Winston itself or at least have a standard configuration that makes this issue clear.

@GregTurner
Copy link

+1

@indexzero
Copy link
Member

The DailyRotateFile transport was moved to a separate module (winston-daily-rotate-file) as of winston@2.0.0. As such we are closing issues here and tracking their status in a single tracking issue in the new repository.

Please open a new issue on winston-daily-rotate-file to continue the discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants