Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The fix merged in #92 isn't available through npm install sassdown #93

Closed
vitorleite opened this issue Aug 2, 2017 · 1 comment
Closed

Comments

@vitorleite
Copy link

After running a npm install -D sassdown, the node_modules/sassdown/tasks/libs/sassdown.js doesn't have fix #92 applied, causing the task to fail.

I'm not familiar with npm publish, but I believe it just never got published?

I managed to have it working by just using npm install -D nopr/sassdown but would definitely welcome a better solution.

@vitorleite vitorleite changed the title The fix merged in #92 isn't available through npm install The fix merged in #92 isn't available through npm install sassdown Aug 2, 2017
@vitorleite
Copy link
Author

For anyone that, like me, isn't yet too familiar with npm, and is getting this issue without knowing how it should be handled properly. I'm leaving here how I sorted it in my end, since this really isn't an issue with sassdown.

If you're using sassdown@0.2.7 and you're getting the error Warning: Path must be a string. and need to include a fixed version of sassdown to sort this out, you can update your package.json to point to this repository, specifically commit 8d9dc78 which includes a fix and be safeguarded regarding future merges or updates to master, although you might still want them anyway.

"devDependencies": {
    "sassdown": "git://github.com/nopr/sassdown.git#8d9dc78"
}

This actually applies to any npm dependency, if you need to apply a fix, just fork the project, apply the fix, push it to your fork, open a pull request and in the meantime point the dependency to your fork repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant