Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start service if service running #402

Closed
VashchenkoVitaliy opened this issue Feb 7, 2020 · 2 comments · Fixed by #385
Closed

start service if service running #402

VashchenkoVitaliy opened this issue Feb 7, 2020 · 2 comments · Fixed by #385
Labels
Milestone

Comments

@VashchenkoVitaliy
Copy link

Hi!
When you restart the service already running, it displays the following message:
2020-02-07 09:24:35,150 INFO - Starting the service with id 'service-0.0.2'
2020-02-07 09:24:35,212 FATAL - WMI Operation failure: ServiceAlreadyRunning
WMI.WmiException: ServiceAlreadyRunning
at WMI.WmiRoot.BaseHandler.CheckError(ManagementBaseObject result)
at WMI.WmiRoot.InstanceHandler.Invoke(Object proxy, MethodInfo method, Object[] args)
at winsw.WrapperService.Run(String[] _args, ServiceDescriptor descriptor)
at winsw.WrapperService.Main(String[] args)
WMI.WmiException: ServiceAlreadyRunning
at WMI.WmiRoot.BaseHandler.CheckError(ManagementBaseObject result)
at WMI.WmiRoot.InstanceHandler.Invoke(Object proxy, MethodInfo method, Object[] args)
at winsw.WrapperService.Run(String[] _args, ServiceDescriptor descriptor)
at winsw.WrapperService.Main(String[] args)

You can replace it with a more pleasant one for users, for example: "Service is running"
Thanks!

@oleg-nenashev
Copy link
Member

I agree that a log entry still makes sense in this case. My plan to cut a release on the weekend so that I am available if something goes wrong. We can get this improvement into it

@VashchenkoVitaliy
Copy link
Author

thanks, ready to be a tester :)

@nxtn nxtn added this to the 2.6.0 milestone Mar 25, 2020
@winsw winsw locked as resolved and limited conversation to collaborators Mar 25, 2020
@nxtn nxtn modified the milestone: 2.6.0 Mar 25, 2020
@nxtn nxtn added the bug label Mar 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants