Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MomentJS outdated #825

Open
WebVPF opened this issue Jan 24, 2023 · 4 comments
Open

MomentJS outdated #825

WebVPF opened this issue Jan 24, 2023 · 4 comments

Comments

@WebVPF
Copy link
Contributor

WebVPF commented Jan 24, 2023

Winter CMS Build

dev-develop

PHP Version

8.0

Database engine

MySQL/MariaDB

Plugins installed

No response

Issue description

MomentJS outdated:

2023-01-25_001215

https://github.com/wintercms/winter/tree/develop/modules/system/assets/ui/vendor/moment

Steps to replicate

Go to Back-end preferences /backend/backend/preferences and set Timezone to Europe/Kyiv

2023-01-25_001329

Save and go to Dashboard. Open the console in your browser and you will see this error.

Workaround

No response

@bennothommo
Copy link
Member

I'm in the process of switching Moment over to Luxon, which uses the browsers in-built Internationalization API, so this should resolve this issue. :)

@austinderrick
Copy link

austinderrick commented Mar 7, 2024

Hey all,

Since it's been a year since this thread was updated, I thought I'd resurface this in light of this security notice on CVE-2022-31129, which is starting to get flagged by security scanners.

@LukeTowers
Copy link
Member

@bennothommo any updates on the switch to Luxon?

@bennothommo
Copy link
Member

@LukeTowers I'd attempted it in this PR - I think it was working from memory - but I got stuck in the weeds with migrating absolutely everything to Snowboard/Mix and ended up in a huge merge conflict.

I can certainly revisit this and try and convert things a bit more piece-meal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants