Fix url validation. fixes #97

server_test.py

@@ -73,6 +73,7 @@
 }
 url_fail = 'http://doesnotwork.example.com'
 url_redir = 'http://example.com'
+uri_ = '/home/user/file'
 #url_timeout = 'http://...'
 
 
@@ -88,6 +89,9 @@ def test_url_1(self):
     def test_url_2(self):
         self.assertFalse(server.url_fails(url_redir))
 
+    def test_url_3(self):
+        self.assertFalse(server.url_fails(uri_))
+
 
 class DBHelperTest(unittest.TestCase):
     def setUp(self):

utils.py

@@ -52,14 +52,11 @@ def json_dump(obj):
 
 
 def url_fails(url):
-    if validate_url(url):
-        try:
+    try:
+        if validate_url(url):
             obj = requests.head(url, allow_redirects=True)
-            if obj.status_code == 200:
-                return False
-            else:
-                return True
-        except (requests.ConnectionError, AssertionError):
-            return True
-    else:
+            assert obj.status_code == 200
+    except (requests.ConnectionError, AssertionError):
         return True
+    else:
+        return False