Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetty 10 support #1967

Closed
reta opened this issue Sep 20, 2022 · 9 comments
Closed

Jetty 10 support #1967

reta opened this issue Sep 20, 2022 · 9 comments

Comments

@reta
Copy link
Contributor

reta commented Sep 20, 2022

The Jetty 10 is the next (last?) javax.* compatible release branch: JDK 11 base line, new APIs. It woud be great to have wiremock to support Jetty 10, along with Jetty 9 (and Jetty 11 [1]).

@tomakehurst wdyt? Once we done with Jetty 11 [1], we could also work on supporting Jetty 10, preferably alongside with Jetty 9, so wiremock could be used in wider range of applications (should be easier at least with respect to fileupload).

[1] #1760

@tomakehurst
Copy link
Member

I feel like this probably won't be worth the amount of noise and support headaches this will cause, especially since Jetty 10 is also JVM 11+.

@tomakehurst
Copy link
Member

What would be more interesting is a build that uses the in-built Java HTTP client and server rather than Jetty + Apache.

@reta
Copy link
Contributor Author

reta commented Sep 22, 2022

I feel like this probably won't be worth the amount of noise and support headaches this will cause, especially since Jetty 10 is also JVM 11+.

That is right, there are some implications, do you mind if I keep this issue open for some time to see if there is an interest from community to support Jetty 10?

What would be more interesting is a build that uses the in-built Java HTTP client and server rather than Jetty + Apache.

thanks @tomakehurst, this is interesting idea, afaik client is certainly fine but server lacks tons of features (fe. HTTP/2 support, ... [1]), so it may not be an equivalent replacement.

[1] https://docs.oracle.com/en/java/javase/15/docs/api/jdk.httpserver/com/sun/net/httpserver/package-summary.html

@tomakehurst
Copy link
Member

Agreed it wouldn't support everything that Jetty can, but a large proportion of WireMock's use is plain HTTP/1.1, without faults, HTTP/2 or any of the more advanced features.

Being able to support the majority cases with a dependency-light version could still be very useful.

@oleg-nenashev
Copy link
Member

@tomakehurst AFAICT it is in the scope for WireMock 3.0, because Jetty 11 support is already in the codebase. Please correct me if I am wrong

@oleg-nenashev
Copy link
Member

FTR #1760

@tomakehurst
Copy link
Member

Yep, this is now obsolete.

@natan-abolafya
Copy link

Hi there. Just wanted to comment for visibility.
We are migrating our application to jetty 10 from 9 right now (dropwizard 2->3). It is kind of a middle step so the changes are smaller. We'll probably go to jetty 11 some time later.

But now we can use neither wiremock 2 nor 3 as the jetty versions don't match and the dependencies pulled don't align.
Do you have any tips to work around this?

@reta
Copy link
Contributor Author

reta commented May 19, 2023

Do you have any tips to work around this?

@natan-abolafya the workaround that works for us is to use wiremock-jre8-standalone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

4 participants