Fix of #1679 - Respect keyStoreType when loading keystores. #2003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the provided keyStoreType when loading keystores. Note that documentation in https://wiremock.org/docs/https/ doesn't actually work - keystores are always attempted to be loaded with the default keystore type. This seems to be a regression. The type is respected in the Java 7 version of wiremock 2.27.2.
|
Please let me know if there is anything further that should be done to this pull request. |
|
Thanks for this, sorry it's taken a while to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the provided keyStoreType when loading keystores.
Note that documentation in https://wiremock.org/docs/https/ doesn't actually work - keystores are always attempted to be loaded with the default keystore type.
This seems to be a regression. The type is respected in the Java 7 version of wiremock 2.27.2.