Fixed clock skew problems with dynamically created certificates #2019
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue when using dynamically generated certificates for TLS connections to Wiremock regarding the certificate validity start time. The certificates are generated with validity start time being the same instant as the request arrives. If Wiremock runs at the same machine as the client, the problem doesn't manifest itself as they are both using the same clock. However, if the client is somewhere else and its time lags behind the Wiremock machine's time, even if it's an infinitesimal difference, the certificates won't be marked as valid.
To fix the clock skew problem, the certificates are now generated using a day before the present moment as the start time. This avoids the problem.