Skips NPE when a multipart could not be parsed #2035
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recording the body instead.
This can happen when content of the multipart is not a file, so there is no header with content disposition giving it a filename. E.g. an OData $batch request.
Wiremock is currently failing the request, giving a 500 back because of the NPE, even when proxying when we got proper data back.
edit went a bit further on the library and saw what was going on, I assumed the lib I was using bad generating the request wrong and hence couldn't be parsed, but really wiremock assumes is going to be files whose parsing will work, not a bad assumption but it doesn't fit certain cases and the NPE is bad.