Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/multi value matcher for query params and headers #2110

Conversation

kapishmalik
Copy link
Contributor

resolves #398

@tomakehurst Could you please check the approach and implementation? If it looks good, I will add more UTs.

I have added functional tests to test multi-value matchers.

@tomakehurst
Copy link
Member

Please could you also add some tests to PlainTextDiffRendererTest showing diffs when multi-valued query params and headers don't match with both includes and hasExactly.

@tomakehurst
Copy link
Member

@kapishmalik this is breaking the Windows build at the moment, which has probably got something to do with line break characters. Could you try changing these in your diff example files to make them consistent with the others?

@tomakehurst tomakehurst merged commit 06397ad into wiremock:master Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify request with duplicate query params
2 participants