-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/multi value matcher for query params and headers #2110
Merged
tomakehurst
merged 12 commits into
wiremock:master
from
kapishmalik:feature/multi-value-matcher-for-query-params-and-headers
Mar 28, 2023
Merged
Feature/multi value matcher for query params and headers #2110
tomakehurst
merged 12 commits into
wiremock:master
from
kapishmalik:feature/multi-value-matcher-for-query-params-and-headers
Mar 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-matcher-for-query-params-and-headers
…-matcher-for-query-params-and-headers
tomakehurst
reviewed
Mar 23, 2023
src/main/java/com/github/tomakehurst/wiremock/client/BasicMappingBuilder.java
Outdated
Show resolved
Hide resolved
tomakehurst
reviewed
Mar 23, 2023
src/main/java/com/github/tomakehurst/wiremock/matching/MultiValuePattern.java
Outdated
Show resolved
Hide resolved
tomakehurst
reviewed
Mar 23, 2023
src/main/java/com/github/tomakehurst/wiremock/matching/MultiValuePattern.java
Show resolved
Hide resolved
tomakehurst
reviewed
Mar 23, 2023
src/test/java/com/github/tomakehurst/wiremock/StubbingAcceptanceTest.java
Outdated
Show resolved
Hide resolved
Please could you also add some tests to |
@kapishmalik this is breaking the Windows build at the moment, which has probably got something to do with line break characters. Could you try changing these in your diff example files to make them consistent with the others? |
tomakehurst
reviewed
Mar 23, 2023
tomakehurst
reviewed
Mar 23, 2023
…-matcher-for-query-params-and-headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #398
@tomakehurst Could you please check the approach and implementation? If it looks good, I will add more UTs.
I have added functional tests to test multi-value matchers.