Add support filename template #2136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Is there a related GitHub issue? Would be nice to have it or some description in the pull request as https://github.com/wiremock/wiremock/blob/master/CONTRIBUTING.md#before-opening-a-pr recommends.
Bonus points for a documentation update too.
tomakehurst
reviewed
Apr 17, 2023
src/main/java/com/github/tomakehurst/wiremock/core/WireMockConfiguration.java
Outdated
Show resolved
Hide resolved
tomakehurst
reviewed
Apr 17, 2023
src/main/java/com/github/tomakehurst/wiremock/standalone/CommandLineOptions.java
Outdated
Show resolved
Hide resolved
tomakehurst
reviewed
Apr 17, 2023
src/main/java/com/github/tomakehurst/wiremock/common/filemaker/FilenameMaker.java
Outdated
Show resolved
Hide resolved
added 4 commits
April 18, 2023 14:43
tomakehurst
reviewed
Apr 18, 2023
src/main/java/com/github/tomakehurst/wiremock/core/WireMockConfiguration.java
Outdated
Show resolved
Hide resolved
added 2 commits
April 18, 2023 17:33
… and replace with FilenameMaker
tomakehurst
reviewed
Apr 19, 2023
src/test/java/com/github/tomakehurst/wiremock/common/SafeNamesTest.java
Outdated
Show resolved
Hide resolved
tomakehurst
reviewed
Apr 20, 2023
src/test/java/com/github/tomakehurst/wiremock/common/FilenameMakerTest.java
Outdated
Show resolved
Hide resolved
|
When I try running it standalone and creating a persistent stub I get an NPE thrown. I'll push a failing test for this + the name logic to your branch. |
lmartelli
reviewed
Apr 23, 2023
| private static final String NAME_TEMPLATE = "{{{name}}}-"; | ||
| private static final Pattern NON_ALPHANUMERIC = Pattern.compile("[^\\w-.]"); | ||
| private static final String DEFAULT_EXTENSION = ".json"; | ||
| private static final String POINT = "."; |
There was a problem hiding this comment.
I believe DOT is more commonly used in this context.
added 3 commits
April 24, 2023 15:15
…an prefixed. Wrapped the stub mapping into a model used for filename templates in order to normalise the URL and simplify access to common attributes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In scope of this PR implemented:
CommandLineOptionsandWireMockConfiguration;SafeFilenameutil class. Replaced with newFilenameMakerclass which based on filename template;