feat: add a requestedFor method allowing to pass Http method as parameter

[ytvnr]

It is useful for parameterized test, when you also use request(String method, UrlPattern urlPattern)

So you are able to write your test like this:

@ParameterizedTest
@ValueSource(strings = {"GET", "POST", "PUT", "HEAD", "TRACE", "PATCH", "OPTIONS", "DELETE", "ANY", "RANDOM"})
public void verifyRequestedForSameMethodAsRequest(String method) {
    wiremock.stubFor(request(method, urlEqualTo("/methods")).willReturn(ok("response"));
    // ... Test stuff here
    verify(requestedFor(method, urlEqualTo("/methods")));
}

• I look at https://wiremock.org/docs/verifying/ and there is not an exhaustive list of the applicable method, so I did not modified the documentation

References

• Add requestedFor method accepting string http method as a param #2174

Submitter checklist

• The PR request is well described and justified, including the body and the references
• The PR title represents the desired changelog entry
• The repository's code style is followed (see the contributing guide)
• Test coverage that demonstrates that the change works as expected
• For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

[oleg-nenashev]

Definitely +1. I would rather deprecate the older methods TBH, because they may cause quite a lot of confusion. Also agree about the documentation, though it would be great to document this particular method there

[ytvnr]

@oleg-nenashev, thank you for the review.
Do you want me to deprecate the older methods in another commit ?
Maybe it would be the opportunity to add methods overload taking the RequestMethod as a parameter and not just a string ?
We would have the additional:

• RequestPatternBuilder requestedFor(HttpMethod method, UrlPattern urlPattern)
• MappingBuilder request(HttpMethod method, UrlPattern urlPattern)
  wdyt ?

[oleg-nenashev]

No strong opinion, I guess @tomakehurst should make a call on deprecation

[tomakehurst]

Please could you run ./gradlew spotlessApply and push the changes?

[tomakehurst]

Re deprecation, I assume you're talking about getRequestedFor(...), postRequestedFor(...) etc.?

If so, I don't think we ought to deprecate. They're convenience DSL methods for the most commonly used HTTP methods, and can co-exist with the general case.

[ytvnr]

Hi @tomakehurst, I just forced push.
Sorry I did not know about this command.

[tomakehurst]

Merging the latest from master should fix the test error

[ytvnr]

It should be ok @tomakehurst (at least ./gradlew check worked locally 😄 )