Replace com.google.common.base.Function (partly)

[pks-1981]

Replace com.google.common.base.Function

References

• Replace Guava classes Optional, Predicate and Function with JDK replacements in JDK #2111

Submitter checklist

• The PR request is well described and justified, including the body and the references
• The PR title represents the desired changelog entry
• The repository's code style is followed (see the contributing guide)
• Test coverage that demonstrates that the change works as expected
• For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

[pks-1981]

@tomakehurst LoggedRequestTest is broken(((
but is not me)))

[tomakehurst]

Sorry fixed it, if you want to rebase

[timtebeek]

Quick reminder that there's this recipe to broadly replace guava:
https://docs.openrewrite.org/recipes/java/migrate/guava/noguava

And this recipe to specifically replace function:
https://docs.openrewrite.org/recipes/java/migrate/guava/preferjavautilfunction

Could be worth exploring either for this pull request.

[pks-1981]

Quick reminder that there's this recipe to broadly replace guava: https://docs.openrewrite.org/recipes/java/migrate/guava/noguava

And this recipe to specifically replace function: https://docs.openrewrite.org/recipes/java/migrate/guava/preferjavautilfunction

Could be worth exploring either for this pull request.

Quick reminder that there's this recipe to broadly replace guava: https://docs.openrewrite.org/recipes/java/migrate/guava/noguava

And this recipe to specifically replace function: https://docs.openrewrite.org/recipes/java/migrate/guava/preferjavautilfunction

Could be worth exploring either for this pull request.

Hello
Do you mean make "com.google.common.base.Joiner" apart from this MR?
It's to small for MR, IMHO...

[timtebeek]

Hello Do you mean make "com.google.common.base.Joiner" apart from this MR? It's to small for MR, IMHO...

I mean to say that some of the changes you're making here manually can also be made through automation. That might mean you can accomplish more in the same time.

Here's another recipe that creates some of the same changes I see you make here:
https://docs.openrewrite.org/recipes/java/cleanup/uselambdaforfunctionalinterface

[pks-1981]

@tomakehurst @timtebeek
Please look at StringValuePatternTest.
I can remake it without com.google.common.base.Function. But in my opinion it does nothing ... or I'm debugging incorrectly)))

[tomakehurst]

Thanks!