Improve handlebars performance on large templates #2211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mahoney
force-pushed
the
efficient-handlebars
branch
3 times, most recently
from
f6fbec5
to
d09b13d
Compare
Handlebars `TextStringBuilder` has a very poor buffer growth strategy. It increases it by the length of the string to be appended, so *every* append causes *all* the existing data to be copied to a new location in memory. `java.io.StringBuilder` has a much better approach of doubling the capacity of the buffer each time it is too small, resulting in far fewer copies. Additionally, it seems to me that setting the initial capacity to double the size of the template will minimise the chances of a copy being needed at all.
Mahoney
force-pushed
the
efficient-handlebars
branch
from
d09b13d
to
216f025
Compare
|
I've also raised jknack/handlebars.java#1066 to improve upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handlebars
TextStringBuilderhas a very poor buffer growth strategy.It increases it by the length of the string to be appended, so every append causes all the existing data to be copied to a new location in memory.
java.io.StringBuilderhas a much better approach of doubling the capacity of the buffer each time it is too small, resulting in far fewer copies.Additionally, it seems to me that setting the initial capacity to double the size of the template will minimise the chances of a copy being needed at all.
Submitter checklist
For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org