Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace com.google.common.io.BaseEncoding by java.util.Base64 #2225

Merged
merged 5 commits into from
Jul 5, 2023
Merged

Replace com.google.common.io.BaseEncoding by java.util.Base64 #2225

merged 5 commits into from
Jul 5, 2023

Conversation

pks-1981
Copy link
Contributor

@pks-1981 pks-1981 commented Jun 18, 2023 •
edited

Replace com.google.common.io.BaseEncoding by java.util.Base64

References

#2111

Submitter checklist

  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@oleg-nenashev oleg-nenashev self-requested a review July 4, 2023 10:28
@pks-1981
Copy link
Contributor Author

pks-1981 commented Jul 5, 2023

@oleg-nenashev
And here, the last commit didn't show up
image

@tomakehurst tomakehurst merged commit b0ac8fb into wiremock:master Jul 5, 2023
5 of 7 checks passed
@pks-1981 pks-1981 deleted the base64 branch July 5, 2023 12:08
@oleg-nenashev oleg-nenashev added the chore Maintenance label Jul 5, 2023
@picimako picimako mentioned this pull request Jul 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev Awaiting requested review from oleg-nenashev

Assignees
No one assigned
Labels
chore Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pks-1981 @tomakehurst @oleg-nenashev