Replace com.google.common.base.MoreObjects.firstNonNull & com.google.common.base.Preconditions.checkArgument by Java alternatives #2228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 19, 2023 09:04
… com.google.common.base.Preconditions.checkArgument
… com.google.common.base.Preconditions.checkArgument
… com.google.common.base.Preconditions.checkArgument
… com.google.common.base.Preconditions.checkArgument
oleg-nenashev
requested changes
Jul 4, 2023
| @@ -27,7 +27,7 @@ public abstract class AbstractScenarios implements Scenarios { | |||
|
|
|||
| private final ScenariosStore store; | |||
|
|
|||
| public AbstractScenarios(ScenariosStore store) { | |||
| protected AbstractScenarios(ScenariosStore store) { | |||
There was a problem hiding this comment.
Revert? Seems to be a legit API
| @@ -48,7 +48,7 @@ public abstract class AbstractStubMappings implements StubMappings { | |||
| protected final List<StubLifecycleListener> stubLifecycleListeners; | |||
| protected final StubMappingStore store; | |||
|
|
|||
| public AbstractStubMappings( | |||
| protected AbstractStubMappings( | |||
added 3 commits
July 5, 2023 08:32
|
@oleg-nenashev |
added 2 commits
July 5, 2023 12:32
oleg-nenashev
changed the title
Is it still actual? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal. Replacing com.google.common.base.MoreObjects.firstNonNull & com.google.common.base.Preconditions.checkArgument
References
#2111
Submitter checklist