Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace com.google.common.base.Charsets.UTF_8 -> java.nio.charset.StandardCharsets.UTF_8. Tests. #2246

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Replace com.google.common.base.Charsets.UTF_8 -> java.nio.charset.StandardCharsets.UTF_8. Tests. #2246

merged 1 commit into from
Jul 5, 2023

Conversation

pks-1981
Copy link
Contributor

@pks-1981 pks-1981 commented Jul 5, 2023 •
edited

Replace com.google.common.base.Charsets.UTF_8 -> java.nio.charset.StandardCharsets.UTF_8. Tests.

References

#2111

Submitter checklist

  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@pks-1981 pks-1981 requested a review from a team as a code owner July 5, 2023 12:06
@tomakehurst tomakehurst merged commit 22945aa into wiremock:master Jul 5, 2023
7 checks passed
@pks-1981 pks-1981 deleted the uft8_tests branch July 5, 2023 18:17
@oleg-nenashev oleg-nenashev added the chore Maintenance label Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mahoney Mahoney Mahoney approved these changes

Assignees
No one assigned
Labels
chore Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pks-1981 @Mahoney @tomakehurst @oleg-nenashev