Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds WiremockNetworkTrafficListeners #2283

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Adds WiremockNetworkTrafficListeners #2283

merged 1 commit into from
Jul 25, 2023

Conversation

gsmith85
Copy link
Contributor

Provides factory methods for creating arbitrary notifying traffic listeners.

References

#2139 (comment)

Submitter checklist

  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@gsmith85
Adds WiremockNetworkTrafficListeners
788d0fd 
Provides factory methods for creating arbitrary notifying traffic listeners.
@gsmith85 gsmith85 requested a review from a team as a code owner July 21, 2023 22:02
@gsmith85
Copy link
Contributor Author

@oleg-nenashev If we're going to move forward with this I can add more robust test coverage, but let's start by discussing if the API meets your needs and we can go from there.

oleg-nenashev
oleg-nenashev reviewed Jul 22, 2023
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. Needs @tomakehurst to verify

@oleg-nenashev oleg-nenashev added enhancement extensibility Changes related to improving WireMock extensibility needs-tom Tom's Train Project :) labels Jul 22, 2023
oleg-nenashev
oleg-nenashev approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am +1 for this patch, it is a good addition for further extensibility IMHO

@tomakehurst tomakehurst merged commit e5312b7 into wiremock:master Jul 25, 2023
7 checks passed
@tomakehurst
Copy link
Member

Thanks!

Please could we get a PR against the 3.x website repo adding some docs for this?
https://github.com/wiremock/wiremock.org/tree/3.0.0-beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

@tomakehurst tomakehurst Awaiting requested review from tomakehurst

Assignees
No one assigned
Labels
enhancement extensibility Changes related to improving WireMock extensibility needs-tom Tom's Train Project :)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gsmith85 @tomakehurst @oleg-nenashev