Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Guava by JDK (Partly) #2297

Merged
merged 3 commits into from
Aug 7, 2023
Merged

Replace Guava by JDK (Partly) #2297

merged 3 commits into from
Aug 7, 2023

Conversation

pks-1981
Copy link
Contributor

@pks-1981 pks-1981 commented Aug 4, 2023 •
edited

Replace Guava by JDK (Partly)
#2111

Submitter checklist

  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@pks-1981 pks-1981 requested a review from a team as a code owner August 4, 2023 13:12
@pks-1981
Copy link
Contributor Author

pks-1981 commented Aug 5, 2023

@tomakehurst @oleg-nenashev
please look MR how it will be possible

@oleg-nenashev oleg-nenashev added the chore Maintenance label Aug 6, 2023
oleg-nenashev
oleg-nenashev approved these changes Aug 6, 2023
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall

src/main/java/com/github/tomakehurst/wiremock/common/ContentTypes.java Outdated Show resolved Hide resolved
src/main/java/com/github/tomakehurst/wiremock/core/WireMockApp.java Outdated Show resolved Hide resolved
@oleg-nenashev oleg-nenashev merged commit ac177a3 into wiremock:master Aug 7, 2023
7 checks passed
@pks-1981 pks-1981 deleted the guava2 branch August 8, 2023 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
chore Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pks-1981 @oleg-nenashev