Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Guava by JDK (Partly) #2305

Merged
merged 34 commits into from
Aug 29, 2023
Merged

Replace Guava by JDK (Partly) #2305

merged 34 commits into from
Aug 29, 2023

Conversation

pks-1981
Copy link
Contributor

@pks-1981 pks-1981 commented Aug 9, 2023 •
edited

Replace Guava by JDK (Partly)
#2111

Submitter checklist

  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@pks-1981 pks-1981 requested a review from a team as a code owner August 9, 2023 12:00
@pks-1981
Copy link
Contributor Author

pks-1981 commented Aug 9, 2023

@tomakehurst @oleg-nenashev
please look MR how it will be possible

@oleg-nenashev oleg-nenashev added the chore Maintenance label Aug 9, 2023
@pks-1981
Copy link
Contributor Author

@tomakehurst @oleg-nenashev
MR finished. please look how it will be possible.

Kirill Peshin added 2 commits August 22, 2023 20:33
oleg-nenashev
oleg-nenashev reviewed Aug 24, 2023
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small compatibility breaking change. Thanks @pks-1981 !

src/main/java/com/github/tomakehurst/wiremock/matching/ContentPatternDeserialiser.java Outdated Show resolved Hide resolved
src/main/java/com/github/tomakehurst/wiremock/matching/MatchesXPathPattern.java Outdated Show resolved Hide resolved
oleg-nenashev
oleg-nenashev approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @pks-1981!

@tomakehurst tomakehurst merged commit 439a7cf into wiremock:master Aug 29, 2023
7 checks passed
@tomakehurst
Copy link
Member

Thanks!

@pks-1981 pks-1981 deleted the guava3 branch August 29, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

@tomakehurst tomakehurst Awaiting requested review from tomakehurst

Assignees
No one assigned
Labels
chore Maintenance
Projects
None yet
Milestone
wiremock-3.0-final-merges
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pks-1981 @tomakehurst @oleg-nenashev