Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requirements without specific version #20

Closed
chenjr0719 opened this issue Dec 4, 2018 · 2 comments
Closed

Requirements without specific version #20

chenjr0719 opened this issue Dec 4, 2018 · 2 comments

Comments

@chenjr0719
Copy link
Collaborator

@benchuang11046 Notice that we remove all versions of requirements(here). This might cause some issues when using run_jnb because of mismatch version with nbconvert. Maybe we still need to use fixed version of all modules in both jupyter_api_default_requirements.txt and jupyter_app_default_requirements.txt. What's your thought?

@benchuang11046
Copy link
Collaborator

Yes, we need to fix version in both default requirements.
Here will append user requirements if the requirement not in default.
Therefore, it must be the fix version in analytics requirements.txt. Based on the jupyter_api_default_requirements.txt and jupyter_app_default_requirements.txt.
I think it's ok.

@chenjr0719
Copy link
Collaborator Author

Ok, I found I just missing some lines of code. Understand what happened about requirements in parser.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants