Skip to content
This repository has been archived by the owner on Aug 25, 2022. It is now read-only.

Differenciate the timeout option #60

Open
Taluu opened this issue Aug 13, 2014 · 0 comments
Open

Differenciate the timeout option #60

Taluu opened this issue Aug 13, 2014 · 0 comments
Labels
improvement

Comments

@Taluu
Copy link
Contributor

Taluu commented Aug 13, 2014

Currently, there is only one "timeout" option. I think it would be better to differenciate between the timeout made at the connection (during the handshake per example) and the one during the connection (set on the stream)
@Taluu Taluu removed the 3.0 label Jan 30, 2015
DiaconuFlorinNarcis added a commit to DiaconuFlorinNarcis/elephant.io that referenced this issue May 29, 2017
@DiaconuFlorinNarcis
Fix Client->read() function
fcadd2d 
The kind of change this PR does introduce

- [x]  a bug fix
- [ ]  a new feature
- [x]  an update to the documentation
- [x]  a code change that improves performance
- [ ]  other

Current behavior
Client->read() is hanging the script until data is received.
New behavior
Client->read() will return empty string if no data is received.
Other information (e.g. related issues)
This answers Wisembly#73, Wisembly#149, Wisembly#137 and perhaps Wisembly#60
@DiaconuFlorinNarcis DiaconuFlorinNarcis mentioned this issue May 29, 2017
Closed
5 tasks
@wirwolf wirwolf mentioned this issue Mar 22, 2019
Open
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Taluu