Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodetaint controller is watching the pod template annotation instead of the daemonset annotation #22

Open
jacksontj opened this issue Apr 25, 2024 · 0 comments

Comments

@jacksontj
Copy link
Contributor

When setting up nodetaint in a cluster we noticed that it was finding 0 daemonsets even though we believed we had it configured. After digging into the code I found that it is checking the spec.template.annotations which is the annotation that will end up on the ds pod -- not the ds itself.

This is a bit counter-intuitive, id expect it to check the annotation of the daemonset directly. Given this would be backwards incompatible maybe we could have it check both?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant