Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] [owo-ui] Add scrollable text in case it doesn't fit in #220

Open
Zailer43 opened this issue Mar 7, 2024 · 0 comments
Open

Comments

@Zailer43
Copy link
Contributor

Zailer43 commented Mar 7, 2024

Description

It would be good for owo-lib to support ClickableWidget.drawScrollableText. This is useful in case the component has a certain width and exceeds it. This can happen in situations like parameters (for example, if it's an item and they use Waxed Exposed Cut Copper Stairs, clearly you're not going to change the size just for this specific case) or translations

ButtonComponent

currently, if a horizontal sizing is not specified, the content sizing adjusts to the text. If a horizontal sizing is set and it exceeds it, the text overflows the button. In contrast, vanilla in recent versions uses ClickableWidget.drawScrollableText, you can see it on some buttons if you change the language (for example, Spanish in the accessibility screen)

LabelComponent

currently, if a horizontal sizing is not specified, the content sizing adjusts to the label. If a horizontal sizing is set, and in case it exceeds it, it breaks into multiple lines. It would be nice to have an option that requires a horizontal sizing and uses ClickableWidget.drawScrollableText

OwoUIDrawContext

perhaps it would be good to add OwoUIDrawContext.drawScrollableText? In case someone needs to use it and thus avoids having to use an access widener

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant