Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for verbosity level. #2

Closed
wants to merge 1 commit into from
Closed

Conversation

ucarion
Copy link

@ucarion ucarion commented Jan 6, 2015

facebookarchive/libwit#1 added a verbosity argument to libwit, but libwit-ruby unconditionally sets this value to 4, the highest possible level.

This PR adds an optional supplemental argument to Wit#init that lets users specify their desired log level:

# The `nil` is to use the default device_opt, the `0` tells Wit not to log at all
Wit.init(nil, 0)

I haven't put any documentation in because I'm not sure where that would go here.

@onionjake
Copy link

+1

@georgecoltart
Copy link

+1

@patapizza
Copy link
Member

Just added -- see #4

@patapizza patapizza closed this Apr 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants