Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

astro@3.4.0 and @astrojs/sitemap@3.0.2 using vulnerable version of Zod #8938

Closed
1 task
josephshambrook opened this issue Oct 27, 2023 · 4 comments · Fixed by #8762
Closed
1 task

astro@3.4.0 and @astrojs/sitemap@3.0.2 using vulnerable version of Zod #8938

josephshambrook opened this issue Oct 27, 2023 · 4 comments · Fixed by #8762
Assignees

Comments

@josephshambrook
Copy link

josephshambrook commented Oct 27, 2023

Astro Info

Astro                    v3.4.0
Node                     v18.18.0
System                   Linux (x64)
Package Manager          npm
Output                   static
Adapter                  none
Integrations             @astrojs/mdx
                         @astrojs/sitemap

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

Running npm audit on a new Astro project raises the following vulnerability with Zod v3.22.1, currently used by both astro@3.4.0 and @astrojs/sitemap@3.0.2.

The vulnerability in Zod is fixed after v3.22.3 (latest version is v3.22.4).

What's the expected result?

Running npm audit should not find any security vulnerabilities within Astro.

Link to Minimal Reproducible Example

https://stackblitz.com/edit/withastro-astro-jqpxng?file=package.json

Participation

  • I am willing to submit a pull request for this issue.
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Oct 27, 2023
@matthewp matthewp added - P5: urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority) and removed needs triage Issue needs to be triaged labels Oct 27, 2023
@matthewp matthewp self-assigned this Oct 27, 2023
@matthewp matthewp removed the - P5: urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority) label Oct 27, 2023
@matthewp
Copy link
Contributor

Hm, Astro is using Zod 3.21.1 not 3.22.1. Are you sure this affects us?

@jacobdalamb
Copy link
Contributor

There's a PR already for this issue

@josephshambrook
Copy link
Author

Hm, Astro is using Zod 3.21.1 not 3.22.1. Are you sure this affects us?

I believe so yes; the vulnerability report says it affects all versions under 3.22.1, so 3.21.1 is included.

@josephshambrook
Copy link
Author

Relevant PR: #8762

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants