Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text background color on hover not shown for new landing page #97

Closed
kevinkassimo opened this issue Apr 15, 2021 · 2 comments · Fixed by #100
Closed

Text background color on hover not shown for new landing page #97

kevinkassimo opened this issue Apr 15, 2021 · 2 comments · Fixed by #100

Comments

@kevinkassimo
Copy link
Contributor

From comments in #95:

The text link disappear on hover
CleanShot 2021-04-15 at 09 10 44

This behavior only happens in Safari, but not in Chrome. When a:before (used to draw the green box) content is empty, its width and height are both 0 for Safari. The reason is that inset: 0 (equivalent to top/right/bottom/left: 0) is NOT supported for Safari: https://caniuse.com/?search=inset

https://github.com/snowpackjs/astro/blob/ea33d7b2ab30f6434986bb0d8671e7f681076268/www/public/global.scss#L78

Originally posted by @kevinkassimo in #95 (comment)

Maybe we should use the more conservative top/right/bottom/left combinations here. I'm unable to make a PR directly myself due to no permission + no forking allowed.

@matthewp
Copy link
Contributor

@natemoo-re mind taking a look?

@natemoo-re
Copy link
Member

Thanks a ton for opening this issue! Should have a fix out shortly.

I forgot that we're not running postcss-preset-env to automatically create the fallback values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants