Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摌 DOC: Example/Template color contrast ratios #112

Closed
stramel opened this issue Jul 26, 2021 · 2 comments
Closed

馃摌 DOC: Example/Template color contrast ratios #112

stramel opened this issue Jul 26, 2021 · 2 comments

Comments

@stramel
Copy link

stramel commented Jul 26, 2021

I noticed by default in the examples/templates, the color contrast ratios come up in the accessibility portion of the Lighthouse Audit.

Primarily seems to be these 2 colors:

--theme-accent(--color-orange): #ff5d01 - against white provides ratio of 3.08

and

--theme-text-lighter(--color-gray-400): #9ca3af - against white provides ratio of 2.53

For smaller font sizes, the minimum ratio should be 4.5 to meet AA standards.
For larger font sizes, the minimum ratio should be 3.0 to meet AA standards.

It would great to provide no accessibility issues out of the box on our examples/templates.

@jonathantneal
Copy link
Contributor

I鈥檒l take this one. I recently added an accessibility audit to the docs site that will catch these kinds of coloring issues.

@ghost ghost assigned jonathantneal Jan 13, 2022
@FredKSchott FredKSchott transferred this issue from withastro/astro Jan 29, 2022
@sarah11918
Copy link
Member

Hi @stramel 馃憢 I'm sorry that there was no recent feedback on this issue, but we did recently redesign the doc site themes and colours, and I know we have some outstanding issues/PRs as we finalize things there.

So, I'm going to close this issue here, with thanks for pointing out the contrast ratio. I know we absolutely did look at this when creating a new theme, and I think we might still be fine-tuning it. So, this request is captured elsewhere, but you're welcome to re-open new issues at any time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants