Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve our sub-package file resolver #199

Merged
merged 1 commit into from Feb 13, 2020
Merged

Improve our sub-package file resolver #199

merged 1 commit into from Feb 13, 2020

Conversation

FredKSchott
Copy link
Owner

Fixes #198

Before

"webDependencies": ["solid-js/dom"] // Failed, not found.

After

"webDependencies": ["solid-js/dom"] // Suceess!

yukukotani
yukukotani approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@yukukotani yukukotani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good comments help my understanding 👍

@FredKSchott FredKSchott merged commit 1ab7838 into alias-deep-imports Feb 13, 2020
@FredKSchott FredKSchott deleted the sub-package-resolver branch February 13, 2020 17:01
FredKSchott added a commit that referenced this pull request Feb 13, 2020
@FredKSchott
deep entrypoint imports (#197) and node resolution method fix (#199)
ba70b4a 
* add ability to alias deep imports

* bump the output buffer for tests

* do path resolution as posix

* add typeof check

* use the node resolution method when we can (#199)
@FredKSchott FredKSchott mentioned this pull request Feb 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukukotani yukukotani yukukotani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FredKSchott @yukukotani