Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make possible to import es6 modules without a semicolon in end #398

Merged
merged 1 commit into from
Jun 1, 2020
Merged

Make possible to import es6 modules without a semicolon in end #398

merged 1 commit into from
Jun 1, 2020

Conversation

tlgimenes
Copy link
Contributor

@tlgimenes tlgimenes commented May 31, 2020

Hello guys !

I'm currently trying to use snowpack in my project. However, snowpack can't find my imports.
The problem here is that I'm currently using the shortened import syntax like the one below

import foo from 'bar'

and not the extended one (with a semicolon in the end)

import foo from 'bar';

This PR tries to fix this issue. However I'm not sure if it's the right solution. I'm open for help/comments.

Thanks !

@niltonvasques
Copy link

🙌! This issue was also annoying me the whole day @tlgimenes. Good good!

@tlgimenes tlgimenes changed the title Make possible to import es6 modules without a coma in end Make possible to import es6 modules without a semicolon in end May 31, 2020
@FredKSchott
Copy link
Owner

Yes, thanks! Can't believe I missed that, will merge then and then make another change to make it more reliable (and add a test so that we don't miss it again).

@FredKSchott FredKSchott merged commit 068471b into FredKSchott:master Jun 1, 2020
@stramel
Copy link
Contributor

stramel commented Jun 1, 2020

@FredKSchott even with the updates to the regex I am still running into issues when not using the semi

@FredKSchott
Copy link
Owner

It hasn't been published yet, do you mean on master? If so, can you paste an example of what's not being picked up?

@stramel
Copy link
Contributor

stramel commented Jun 1, 2020

Yeah I was testing with the latest in master linked. I will try to recreate it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants