Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup unresolved import errors #473

Merged
merged 1 commit into from Jun 11, 2020
Merged

Cleanup unresolved import errors #473

merged 1 commit into from Jun 11, 2020

Conversation

FredKSchott
Copy link
Owner

  • Cleanup the "unresolved import" error messages to be more concise.
  • Add documentation to the docs site to start a "troubleshooting" section.
  • Properly exit/fail when an unresolved import is encountered.
    • Bonus: dev/build will no longer clear output if this happens.
  • Add a test.

Currently

Screen Shot 2020-06-10 at 4 41 39 PM

This PR

Screen Shot 2020-06-10 at 4 29 53 PM

@FredKSchott FredKSchott requested a review from a team as a code owner June 10, 2020 23:42
@FredKSchott FredKSchott merged commit 5adee6d into master Jun 11, 2020
@FredKSchott FredKSchott deleted the fail-if-bad-resolve branch June 11, 2020 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drwpow drwpow drwpow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FredKSchott @drwpow