Improve load performance #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FredKSchott
force-pushed
the
wip-perf-improve
branch
from
604e564
to
91f9e7e
Compare
|
What kind of perf improvements did this yield? |
FredKSchott
force-pushed
the
wip-perf-improve
branch
from
91f9e7e
to
25412d5
Compare
|
Should have included in the OP:
The flamegraph implied that this was a 50% startup saving, but my quick manual test of the changes only saw a speedup from |
drwpow
approved these changes
Jun 11, 2020
FredKSchott
force-pushed
the
wip-perf-improve
branch
from
25412d5
to
a8c57c0
Compare
|
I wonder if we swapped got ~28kb |
FredKSchott
commented
Jun 11, 2020
| @@ -66,8 +67,8 @@ export async function wrapCssModuleResponse({ | |||
| hasHmr?: boolean; | |||
| config: SnowpackConfig; | |||
| }) { | |||
| let core = new Core(); | |||
| const {injectableSource, exportTokens} = await core.load(code, url, () => { | |||
| _cssModuleLoader = _cssModuleLoader || new (require('css-modules-loader-core'))(); | |||
There was a problem hiding this comment.
We need to use require() here, since TypeScript's import support forces us to grab the default export off of the module, but that doesn't actually exist. But, we still get type info from the CSSModuleLoader type above.
|
+1, we only use |
stramel
approved these changes
Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off work from https://github.com/GoogleCloudPlatform/require-so-slow
These were our two worst offenders in terms of load time performance impact.