Add @babel/preset-typescript dep to app-template-svelte-typescript #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/lytdqazn0 |
drwpow
commented
Aug 7, 2020
| @@ -15,9 +15,10 @@ | |||
| "dependencies": { | |||
| "@babel/core": "^7.10.5", | |||
| "@babel/preset-env": "^7.10.4", | |||
| "@babel/preset-typescript": "^7.10.4", | |||
There was a problem hiding this comment.
Main change: just add @babel/preset-typescript to app-scripts-svelte
drwpow
force-pushed
the
drwpow/fix-svelte-template
branch
from
c0f14eb
to
2b0c632
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
If you run
npx create-snowpack-app --template app-template-svelte-typescript, then runnpm test, you’ll get an error. This PR fixes that.Since I was touching deps anyway, I just went ahead and updated Jest for everything. All tests should still pass—both for this project as well as all the templates.
Testing