Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tables descendants are not fulll width after moving content tables to display:block. #296

Closed
1 task done
cbontems opened this issue Jul 2, 2023 · 1 comment
Closed
1 task done

Comments

@cbontems
Copy link
Contributor

cbontems commented Jul 2, 2023

What version of starlight are you using?

0.4.0

What version of astro are you using?

2.7.2

What package manager are you using?

pnpm

What operating system are you using?

Mac

What browser are you using?

Chrome

Describe the Bug

As discussed on Discord, PR #177 closing #176 did change display:table to display:block on the table generated in content.

This change has side effects, as without display:table, the table descendants don't behave as expected following the table layout algorithm.

In particular, even with a full witdh table, descendants keep a max-content width and don't use full width. See the stackblitz example with the same Starlight Comparisons table with display:block and display:table.

There may also be accessibility issues with older browsers as well as Safari, but I think @delucis did investigate about this already.

I suggest we explore solutions to solve overflows while keeping the original display:table on table elements.

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-tshqvq?file=src%2Fcontent%2Fdocs%2Findex.mdx

Participation

  • I am willing to submit a pull request for this issue.
@cbontems
Copy link
Contributor Author

cbontems commented Jul 3, 2023

As discussed on discord sticking with current defaults and leaving users adjust depending on their needs.

@cbontems cbontems closed this as completed Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant