Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support external icons since built-in icons are too limited #349

Closed
1 task
dhruvkb opened this issue Jul 17, 2023 · 4 comments
Closed
1 task

Support external icons since built-in icons are too limited #349

dhruvkb opened this issue Jul 17, 2023 · 4 comments
Labels
enhancement Something it would be good to improve

Comments

@dhruvkb
Copy link
Contributor

dhruvkb commented Jul 17, 2023

What version of starlight are you using?

0.5.1

What is your idea?

Since the built-in icons in Starlight are too limited, it would be great if the Card component could work with a different icon set like Font Awesome, Heroicons or Bootstrap.

Why is this feature necessary?

Starlight's built in icon set is extremely limited (~38). The option to integrate with a different icon set would expand the available number of glyphs considerably.

Do you have examples of this feature in other projects?

No response

Participation

  • I am willing to submit a pull request for this issue.
@delucis
Copy link
Member

delucis commented Jul 20, 2023

Thanks for the issue! We’ve adding a few manually so far, but may be worth expanding or supporting customisation. The non-logo icons Starlight currently uses are from the Unicons set: https://github.com/Iconscout/unicons

@delucis delucis added the enhancement Something it would be good to improve label Jul 20, 2023
@lorenzolewis
Copy link
Contributor

Could we look at integrating with https://github.com/natemoo-re/astro-icon/tree/next somehow for this? @natemoo-re is using Iconify to back it and that has the Unicons set in it.

I'm not sure how an "integration within an integration" to have starlight handle this all internally or if this would have to be another layer.

An additional option could be pointing people to that package once component replacement is a think.

@delucis
Copy link
Member

delucis commented Jul 31, 2023

I could chat with @natemoo-re‚ it’s definitely an idea! Not sure when natemoo-re/astro-icon#111 might be released.

@lschierer
Copy link

with iconify's webcomponent support, this would just be adding the import statement import 'iconify-icon'; to the base layout page, you can then use

<iconify-icon icon="mdi:caret-down-outline"></iconify-icon>

or any other icon where ever you like in the mdx pages.

@withastro withastro locked and limited conversation to collaborators Oct 23, 2023
@delucis delucis converted this issue into discussion #967 Oct 23, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
enhancement Something it would be good to improve
Projects
None yet
Development

No branches or pull requests

4 participants