quick fix for #586. A more durable solution is inbound #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When saving to the file system, localStorage is not updated. Unfortunately, since localStorage (and failing that, the fileCache) was used as the source of truth on the client, work would appear to be lost until a hard refresh, and would actually be lost if any edits were made prior to refreshing.
The fix here is fragile, and doesn't handle the case where the user has existing localStorage saves for the file or the case where the user edits in the editor, then the file system, then the editor again without a refresh in between, but it at least fixes the particular case in #586.
A more durable fix will arrive along with the client refactoring work.