Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode integration indicator doesn't work for Insiders Edition #314

Closed
3 of 4 tasks
fwesss opened this issue Jul 23, 2021 · 1 comment
Closed
3 of 4 tasks

VSCode integration indicator doesn't work for Insiders Edition #314

fwesss opened this issue Jul 23, 2021 · 1 comment
Labels
terminal:VSCode Issues related to Visual Studios Code type:bug Something isn't working
Milestone

Comments

@fwesss
Copy link
Contributor

fwesss commented Jul 23, 2021

Sanity checks

  • I have searched github.com/withfig/fig/issues and there are no duplicates of my issue
  • My issue does not relate to a specific CLI completion spec (e.g. git checkout is missing options in git completion spec). If it does, please create your issue here: withfig/autocomplete

Issue Details

Summary

The menu item for VSCode integration will be unchecked if the insiders version of VSCode is installed.

Steps to Reproduce

  1. Install VSCode Insiders edition and VSCode integration.

Expected Results

When the integration is installed, the menu item should be checked and fig diagnostic should report the installation.

Actual Results

Even if the VSCode integration is installed and active, the Fig integrations menu and fig diagnostic will not show it.

Environment

Version 1.0.46 (B250) [U.S.]

UserShell: /usr/local/bin/zsh

Bundle path: /Applications/Fig.app

Autocomplete: true

Settings.json: true

CLI installed: true

CLI tool path: /Users/MEstes/.fig/bin/fig

Accessibility: true

Number of specs: 146

SSH Integration: true

Tmux Integration: true

Keybindings path: /Users/MEstes/.fig/user/keybindings

iTerm Integration: true [Authenticated]

Hyper Integration: false

VSCode Integration: false

Docker Integration: true

Symlinked dotfiles: false

Only insert on tab: false

Installation Script: true

PseudoTerminal Path: Starting

SecureKeyboardInput: false

SecureKeyboardProcess: <none>

Current active process: /usr/local/Cellar/zsh/5.8_1/bin/zsh (27234) - ttys003

Current working directory: /Users/MEstes/bin

Current window identifier: 966/C7ADEB8B-62BC-4D02-B708-F59C15B8A0C3% (com.googlecode.iterm2)

PATH: /Users/MEstes/.oh-my-zsh/custom/plugins/git-open:/Users/MEstes/.composer/vendor/bin:/Users/MEstes/Projects/pihole/scripts:/Users/MEstes/bin/you-git-me:/Users/MEstes/bin:/usr/local/sbin:/usr/local/opt/ruby/bin:/usr/local/opt/php@7.4/sbin:/usr/local/opt/php@7.4/bin:/usr/local/opt/ruby/sbin:/usr/local/opt/ruby/bin:/usr/local/opt/gettext/sbin:/usr/local/opt/gettext/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/MacGPG2/bin:/Applications/Wireshark.app/Contents/MacOS:/Users/MEstes/.fig/bin

FIG_INTEGRATION_VERSION: 4

More Detail

terminal::VSCode

Is this issue related to the docs?

  • Yes
  • No

Anything else?

No response

@fwesss fwesss added NEED_TO_LABEL type:bug Something isn't working terminal:VSCode Issues related to Visual Studios Code and removed NEED_TO_LABEL labels Jul 23, 2021
@mschrage
Copy link
Member

This will be fixed in the next release (v1.0.49). I've completely revamped how the integrations are presented and there will now by a separate entry for VSCode Insiders (if you have it installed).

@mschrage mschrage added this to the v1.0.49 milestone Sep 18, 2021
@fwesss fwesss closed this as completed Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
terminal:VSCode Issues related to Visual Studios Code type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants