Comply with CommonMark 0.30 #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Witiko
added
feature request
good first issue
lua
This was
linked to
issues
Dec 29, 2022
Merge upstream branch main into branch commonmark
Merge upstream branch main into branch commonmark
Merge upstream branch main into branch commonmark
Witiko
force-pushed
the
commonmark
branch
5 times, most recently
from
9635f55
to
e805418
Compare
Witiko
force-pushed
the
commonmark
branch
3 times, most recently
from
7ead3cc
to
61b61d6
Compare
The header attribute context now only spans the heading and its attributes, not the entire section implied by the heading. Entire sections are surrounded by `sectionBegin` and `End` renderers since version 2.21.0 of the Markdown Package for TeX.
Witiko
commented
Jul 20, 2023
Comment on lines
+26733
to
+26735
| if match_link_attributes then | ||
| matching_content = matching_content * Cg(Ct(parsers.attributes^-1), "attributes") | ||
| end |
There was a problem hiding this comment.
@lostenderman: The purpose of built-in syntax extensions was to separate the syntax extensions from the base reader in order to make the code more modular and easier to reason about. In essence, the option options.linkAttributes should not be accessed from the base markdown reader. All code for options.linkAttributes should be encapsulated in M.extensions.link_attributes. Not sure how to get there but the current implementation is a step down in terms of code quality.
Witiko
added a commit
that referenced
this pull request
Jan 6, 2024
As reported by @TeXhackse, testing can take up to 8G RAM with 4 CPUs and batch size 100, which seems excessive. This is related to #226, #308, and #318.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #212 and #29. Funded by project MUNI/33/1654/2022.