New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manage node as service by systemd #1128
Conversation
Hey @bertux this is looking good. What do you think about providing a README file explaining how to use the service? I know it should be obvious for most modern GNU/Linux users. However I think it would be super nice to have some instructions on the big picture, I mean how to download the binary and all the needed files for this service to work. |
Just found out this is totally related to issue #1043 ! |
Thank you I will base the README.md from this content and will correct the location of the service file. I will also a link to this README in https://github.com/witnet/witnet-rust/blob/master/docs/get-started/installation/from-source.md to contribute to the documentation. |
@aesedepece it's finally ready for review, I've kept the README minimal by referencing the documentation of installation from source where I have added to install the systemd service with a dedicated user. Happy to reply your questions about it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! 💪
I agree that's the better option. Please take a look at the contributing guide for specific instructions about commit messages and PGP signing your commits. |
I have followed the contributing guide and now my public GPG key is shared at https://keys.openpgp.org/ and I've followed https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request to squash my commits into one signed commit to be able to merge it with the commit message below : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved!
But I can't still merge it myself so I guess @aesedepece will merge it when he will feel it's the right timing. I hope I won't need to rebase it again by this time. |
Please accept the write access invite here: Then you'll be able to push to master like the gods of git do 😎 |
thank you for the invitation, I've accepted it now and when I've tried my first merge here it proposed only "Rebase and merge" which then failed with error message "Merge attempt failed |
Yes, it sounds like some other PR was merged in the meanwhile, so you need to rebase again and merge right after that. Welcome to open development! 😛 |
thank you for the confirmation, that's what I'm redoing now. I love to be able to contribute directly to your open development :-) |
Co-Authored-By: Adán SDPC <adan@stampery.com>
to make it lighter than using Docker and downloading at every start
it should make possible to run dozens of nodes natively on the host without requiring much