Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manage node as service by systemd #1128

Merged
merged 1 commit into from Apr 14, 2020
Merged

Conversation

bertux
Copy link
Collaborator

@bertux bertux commented Mar 25, 2020

to make it lighter than using Docker and downloading at every start
it should make possible to run dozens of nodes natively on the host without requiring much

@aesedepece
Copy link
Member

Hey @bertux this is looking good.

What do you think about providing a README file explaining how to use the service? I know it should be obvious for most modern GNU/Linux users. However I think it would be super nice to have some instructions on the big picture, I mean how to download the binary and all the needed files for this service to work.

@aesedepece
Copy link
Member

Just found out this is totally related to issue #1043 !

@bertux
Copy link
Collaborator Author

bertux commented Apr 3, 2020

Just found out this is totally related to issue #1043 !

Thank you I will base the README.md from this content and will correct the location of the service file.

I will also a link to this README in https://github.com/witnet/witnet-rust/blob/master/docs/get-started/installation/from-source.md to contribute to the documentation.

@bertux
Copy link
Collaborator Author

bertux commented Apr 10, 2020

@aesedepece it's finally ready for review, I've kept the README minimal by referencing the documentation of installation from source where I have added to install the systemd service with a dedicated user. Happy to reply your questions about it.

docs/get-started/installation/from-source.md Outdated Show resolved Hide resolved
docs/get-started/installation/from-source.md Outdated Show resolved Hide resolved
docs/get-started/installation/from-source.md Outdated Show resolved Hide resolved
docs/get-started/installation/from-source.md Outdated Show resolved Hide resolved
docs/get-started/installation/from-source.md Outdated Show resolved Hide resolved
docs/get-started/installation/from-source.md Outdated Show resolved Hide resolved
docs/get-started/installation/from-source.md Outdated Show resolved Hide resolved
systemd/README.md Outdated Show resolved Hide resolved
systemd/README.md Outdated Show resolved Hide resolved
systemd/README.md Outdated Show resolved Hide resolved
Copy link
Member

@aesedepece aesedepece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! 💪

@aesedepece
Copy link
Member

BTW, @bertux what do you think about backporting #1140 into the runner.sh here once #1140 it is merged?

@bertux bertux requested a review from aesedepece April 13, 2020 11:03
@bertux bertux marked this pull request as draft April 13, 2020 11:07
@bertux bertux marked this pull request as ready for review April 13, 2020 11:13
@bertux
Copy link
Collaborator Author

bertux commented Apr 13, 2020

BTW, @bertux what do you think about backporting #1140 into the runner.sh here once #1140 it is merged?

I didn't want to delay this pull request by backporting it already but when both will be merged then I can create a new pull request for this backport.

@aesedepece
Copy link
Member

BTW, @bertux what do you think about backporting #1140 into the runner.sh here once #1140 it is merged?

I didn't want to delay this pull request by backporting it already but when both will be merged then I can create a new pull request for this backport.

I agree that's the better option.

Please take a look at the contributing guide for specific instructions about commit messages and PGP signing your commits.

@bertux
Copy link
Collaborator Author

bertux commented Apr 13, 2020

BTW, @bertux what do you think about backporting #1140 into the runner.sh here once #1140 it is merged?

I didn't want to delay this pull request by backporting it already but when both will be merged then I can create a new pull request for this backport.

I agree that's the better option.

Please take a look at the contributing guide for specific instructions about commit messages and PGP signing your commits.

I have followed the contributing guide and now my public GPG key is shared at https://keys.openpgp.org/ and I've followed https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request to squash my commits into one signed commit to be able to merge it with the commit message below :
feat(systemd): added systemd integration
@aesedepece would you suggest a better commit message ? is feat(integration) better ?

Copy link
Member

@aesedepece aesedepece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@bertux
Copy link
Collaborator Author

bertux commented Apr 13, 2020

Approved!

But I can't still merge it myself so I guess @aesedepece will merge it when he will feel it's the right timing. I hope I won't need to rebase it again by this time.

@aesedepece
Copy link
Member

Please accept the write access invite here:
https://github.com/witnet/witnet-rust/invitations

Then you'll be able to push to master like the gods of git do 😎

@bertux
Copy link
Collaborator Author

bertux commented Apr 14, 2020

Please accept the write access invite here:
https://github.com/witnet/witnet-rust/invitations

Then you'll be able to push to master like the gods of git do 😎

thank you for the invitation, I've accepted it now and when I've tried my first merge here it proposed only "Rebase and merge" which then failed with error message "Merge attempt failed
Base branch requires signed commits. Rebase merges cannot be automatically signed by GitHub"
So I guess I will need to rebase it again before being able to merge.

@aesedepece
Copy link
Member

Yes, it sounds like some other PR was merged in the meanwhile, so you need to rebase again and merge right after that. Welcome to open development! 😛

@bertux
Copy link
Collaborator Author

bertux commented Apr 14, 2020

Yes, it sounds like some other PR was merged in the meanwhile, so you need to rebase again and merge right after that. Welcome to open development! 😛

thank you for the confirmation, that's what I'm redoing now. I love to be able to contribute directly to your open development :-)

Co-Authored-By: Adán SDPC <adan@stampery.com>
@bertux bertux merged commit da8385b into witnet:master Apr 14, 2020
@bertux bertux deleted the bertux-systemd branch April 14, 2020 15:44
@bertux bertux linked an issue Apr 14, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add systemd service for witnet node
2 participants