Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detox not disabling YellowBox when running tests on 0.59.8 #1382

Closed
doelgonzo opened this issue May 13, 2019 · 2 comments
Closed

Detox not disabling YellowBox when running tests on 0.59.8 #1382

doelgonzo opened this issue May 13, 2019 · 2 comments

Comments

@doelgonzo
Copy link

Describe the bug
On React Native 0.59.8, I am seeing a weird behavior where I am running tests and YellowBox appears to not be disabled. In every previous instance (most lately 0.57), I have seen YellowBox properly disabled when running E2E tests and this was working just fine. This tells me Detox is not disabling the YellowBox, or is no longer compatible with how React Native does it's warnings, anymore.

Now, given YellowBox is not disabled, warnings pop up and the test gestures try to press where buttons would be if the warnings weren't there. If I console.disableYellowBox = true; all my tests pass, so I'm wondering if this has anything to do with the reimplementation of YellowBox or if there is something I am missing in my mocha/detox config.

To Reproduce

  • [ X] I have tested this issue on the latest Detox release and it still reproduces

This did not happen on Detox 10/RN 0.57

Config:
"ios.sim.debug": { "binaryPath": "ios/build/myProject/Build/Products/Debug-iphonesimulator/myProject.app", "build": "npm run ios -- --simulator=\"iPhone 7\"", "type": "ios.simulator", "name": "iPhone 7" }, "ios.sim.release": { "binaryPath": "ios/build/myProject/Build/Products/Release-iphonesimulator/twmobile.app", "build": "xcodebuild -workspace ios/myProject.xcworkspace -scheme myProject -configuration Release -sdk iphonesimulator -derivedDataPath ios/build", "type": "ios.simulator", "name": "iPhone 7" }

Environment (please complete the following information):

  • Detox: 12.8.0
  • React Native: 0.59.8
  • Node: 10.15.3
  • Device: iPhone 7
  • Xcode: 10.2
  • iOS: 12.2
  • macOS: Mojave
@LeoNatan
Copy link
Contributor

Detox makes no attempt to disable yellow boxes, nor should it. It's your responsibility, as an app owner, to do that. We always recommend building in Release so that you do not hit such issues.

@support
Copy link

support bot commented May 13, 2019

We use the issue tracker exclusively for bug reports and feature requests. This issue appears to be a general usage or support question. Instead, please ask a question on Stack Overflow with the detox tag.

@support support bot closed this as completed May 13, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants