[Epic] DAS Phase 1: Global device allocation

[d4vidi]

Description

When using the android.genycloud device type, it is not possible to run multiple detox test … commands in parallel like that:

detox test -c android.geny.release -n Recipe1 & \ # session.id = e54490fd-7cb7-e05a-586e-c3ec23540496
detox test -c android.geny.release -n Recipe2 & \ # session.id = 1acee489-e9d3-4a82-8e50-24f723f60ff8
wait

The problem is that the fastest command would go over the ~/Library/Detox/genycloud-cleanup.lock, e.g.:

[
  {"id":"d9d09cbf-df0b-4044-ae07-32d794a65d49","data":{"name":"Detox.e54490fd-7cb7-e05a-586e-c3ec23540496.w1"}},
  {"id":"39178451-9b6f-43b9-9053-7321294255ab","data":{"name":"Detox.1acee489-e9d3-4a82-8e50-24f723f60ff8.w1"}},
]

and stop all the instances, including the ones that do not belong to its test session.

In this example, if the session e54490fd-7cb7-e05a-586e-c3ec23540496 completes faster and cleans up, then the slower one,1acee489-e9d3-4a82-8e50-24f723f60ff8, will start failing after this, because its device will have been stopped by that moment.

Suggested solution

Move the device allocation to the primary (global) context and stop using lock files in the Genymotion SaaS drivers. The global allocation mechanism will track all the devices created throughout the test session, but since it will be happening in memory, there will no longer be a shared file to fight over. Voila! No file – no problem.

Gameplan

Tasks

Beta Give feedback

1. [Genymotion SaaS] Device name conflict after environment setup timeout #3655
   platform: android status: accepted type: bug 🐞 +3
   
2. Launch emulators sequentially #2106
   domain: stability platform: android status: accepted type: enhancement ⚡️ 📌 pinned +5
   
3. Fix cleanup in multi-worker envs (DAS project) #2894 (--u, --cleanup works incorrectly in Jest (devices are being shut down after each test suite)
4. Race conditions when running multiple "detox test ..." commands in parallel