Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancies in Android web-view testing compared to iOS #4398

Open
6 tasks
asafkorem opened this issue Mar 12, 2024 · 3 comments
Open
6 tasks

Discrepancies in Android web-view testing compared to iOS #4398

asafkorem opened this issue Mar 12, 2024 · 3 comments

Comments

@asafkorem
Copy link
Contributor

asafkorem commented Mar 12, 2024

Objective: Update the Android WebView API to match iOS functionality, focusing on passing the iOS-only tests (:ios:).

Our testing suite has identified gaps in Android's WebView API compared to iOS.

Issues found:

  • atIndex for web-views matching is not implemented.
  • toExist expectation not throwing error on failure.
  • href & hrefContains matching is broken.
  • replaceText & clearText in content-editable elements not supported.
  • getCurrentUrl is throwing error.
  • CORS issues workaround (disableWebKitSecurity)
@asafkorem
Copy link
Contributor Author

asafkorem commented Mar 12, 2024

I'm considering migrating all JS actions and expectations, as implemented on the iOS end, to a common JS infrastructure that builds the code for the invocation (expectation/action), with the native layer only injecting it into the WebView (instead of using Espresso's APIs for web-view testing). This way, we'll implement all functions from one place, ensuring consistent behavior.

I'd like to hear what you think @d4vidi @gosha212 @noomorph

@asafkorem asafkorem changed the title Discrepancies in Android web-view APIs functionality compared to iOS Discrepancies in Android web-view testing compared to iOS Mar 12, 2024
@asafkorem
Copy link
Contributor Author

Yarik suggested to check regarding iframes support (on espresso and on custom JS implementation)

@d4vidi
Copy link
Collaborator

d4vidi commented Mar 24, 2024

@asafkorem I think it's going to be worth it to at least try to reimplement and see whether the outcome is on par. If there's any added value provided by Espresso, that could uncover it, helping us put things in a better perspective.

@asafkorem asafkorem self-assigned this Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants