Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e get stuck #86

Closed
ofiratt opened this issue Jan 24, 2017 · 5 comments
Closed

e2e get stuck #86

ofiratt opened this issue Jan 24, 2017 · 5 comments

Comments

@ofiratt
Copy link

ofiratt commented Jan 24, 2017

please check "should show first screen" at ofiratt/react-native-movies-list@4ba63bd

@brentvatne
Copy link
Contributor

brentvatne commented Feb 27, 2017

same thing happens to me with a super simple assertion

const timeout = 20000;

describe('Example', () => {
  before(done => {
    simulator.relaunchApp(
      { url: 'exp://6b-dt8.notbrent.growler-prowler.exp.direct:80' },
      done
    );
  });

  it('should have welcome screen', () => {
    waitFor(element(by.label('Welcome to Exponent!')))
      .toBeVisible()
      .withTimeout(timeout);
    element(by.label('Got it')).tap();
    expect(element(by.label('Continue as a guest')).toBeVisible());
  });
});

@rotemmiz
Copy link
Member

rotemmiz commented Mar 6, 2017

@ofiratt, the issue is now fixed on your example, and will be released with detox 5.0.0 in the coming days.

@brentvatne can you please supply a demo project with this crash, I want to test the fix on your use case as well

@rotemmiz
Copy link
Member

rotemmiz commented Mar 6, 2017

summary of the issue:
The crash is triggered when a toBeVisible() is called on RCTScrollView (React ScrollView or ListView).
In order for Earl Grey to test that the view is visible it makes some magic inside the view hierarchy, adding a subview to the view it asserts on, causing react-native to crash with RCTAssert “we should only have exactly one subview”.

@LeoNatan
Copy link
Contributor

LeoNatan commented Apr 4, 2017

@rotemmiz Can we close this?

@brentvatne
Copy link
Contributor

brentvatne commented Apr 18, 2017

yup, this is fixed now -- or at least it was for me

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants