Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding toString implementation for RuleViolation and GroupViolation #80

Merged
merged 1 commit into from Jan 4, 2017

Conversation

Diagoras
Copy link
Contributor

This is a shot at addressing issue #78, adding a nice toString implementation for Violation. I'm a little concerned about the recursive aspect though, since a GroupViolation can contain another GroupViolation. Would you prefer that was handled with an @tailrec annotated method or ScalaZ's Trampoline?

@holograph
Copy link
Contributor

Since this is intended for debugging, I wouldn't necessarily worry about performance. I generally like this solution, and if performance becomes an issue, @tailrec is definitely the way to go -- I'm trying to keep dependencies to a minimum, zero if possible.

@holograph holograph merged commit 556c102 into wix-incubator:master Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants