Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Select picker #139

Closed
DCKT opened this issue May 23, 2017 · 5 comments
Closed

[Question] Select picker #139

DCKT opened this issue May 23, 2017 · 5 comments

Comments

@DCKT
Copy link

DCKT commented May 23, 2017

Hello,

I didn't find anything for select a Picker.Item with precision, do you know how to do it ?

Thanks !

@LeoNatan
Copy link
Contributor

LeoNatan commented Jun 6, 2017

For pickers to work with Detox, we need to add API for scrolling from a point to a point, where then you would be able to scroll to the item you desire. We plan to add this soon, and it is tracked in #154.

@LeoNatan LeoNatan closed this as completed Jun 6, 2017
@colinramsay
Copy link

I'm not sure that scrolling is the way to approach pickers. Wouldn't it be better to be able to set a wheel to a particular value?

@rotemmiz
Copy link
Member

rotemmiz commented Jun 8, 2017

@colinramsay you're right, and EarlGrey actually have lots of actions that we can support pretty easily, we just need to expose them with our API.
https://github.com/google/EarlGrey/blob/master/EarlGrey/Action/GREYActions.h

Actually, this can be a great PR.
This is where we invoke EarlGrey methods, and more specifically, configure actions:
https://github.com/wix/detox/blob/master/detox/src/ios/expect.js#L43

@LeoNatan
Copy link
Contributor

LeoNatan commented Jun 8, 2017

+ (id<GREYAction>)actionForSetPickerColumn:(NSInteger)column toValue:(NSString *)value;

Interesting. However, this is a very naive approach, as picker views can have custom views. Still interesting. I'll open a new issue for discussing additional actions we may want to support.

@LeoNatan
Copy link
Contributor

LeoNatan commented Mar 7, 2018

This is being worked on as we speak in #605

@wix wix locked and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants