Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device.openURL pops-up a system alert which can't be turned off with Detox #172

Closed
mbardauskas opened this issue Jun 22, 2017 · 4 comments
Closed

Comments

@mbardauskas
Copy link
Contributor

device.openURL pops-up a system alert which can't be turned off with Detox, it doesn't appear in View hierarchy.
This happens only for the first device.openURL and fails all tests because the app is stuck with the alert. However, if you press Open, the next time you run the tests, the alert doesn't appear and tests pass.

Here's the screenshot of the alert and view hierarchy:
screen shot 2017-06-22 at 16 03 27

@LeoNatan
Copy link
Contributor

LeoNatan commented Jul 5, 2017

Fixed in master.
Please notice there is an API change. device.openURL() now expects to receive a JSON object with at least url key provided with an appropriate value. Other key that can be included is sourceApp, which signals the owner app which app opened it with this URL.

@LeoNatan LeoNatan closed this as completed Jul 5, 2017
@LeoNatan
Copy link
Contributor

LeoNatan commented Jul 5, 2017

@silyevsk This is blocking for people. If the "open sim not through fbsimctl" effort cannot be resolved today, let's please revert and create a release including this fix, so we can let people work. Thanks

@silyevsk
Copy link
Contributor

silyevsk commented Jul 5, 2017

@LeoNatan the fbsimctl thing didn't require a change in detox - it happened due to an old fbsimctl version.

@LeoNatan
Copy link
Contributor

LeoNatan commented Jul 5, 2017

Great. Let’s release a new version.

@wix wix locked and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants