Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running build-framework-cache produces different output directory than expected #380

Closed
LeoNatan opened this issue Nov 2, 2017 · 3 comments

Comments

@LeoNatan
Copy link
Contributor

LeoNatan commented Nov 2, 2017

Switched command line tools from Xcode 9.2 to 9.1, and detox identified the change. After running detox clean-framework-cache && detox build-framework-cache however, Detox still complained that the framework was not built:

detox info 1: Searching for device matching iPhone 7 Plus... 
  1) "before all" hook

  0 passing (674ms)
  1 failing

  1)  "before all" hook:
     Error: /Users/lnatan/Library/Detox/ios/6cf34fb8ac4a2ae2a63622ff93db32d05bc24849/Detox.framework could not be found, this means either you changed a version of Xcode or Detox postinstall script was unsuccessful. 
      To attempt a fix try running 'detox clean-framework-cache && detox build-framework-cache'
      at SimulatorDriver.prepare (/Users/lnatan/Desktop/Code/detox/detox/src/devices/IosDriver.js:32:13)
      at process._tickCallback (internal/process/next_tick.js:103:7)

detox build-framework-cache actually created a different folder, which I renamed to what detox test expected, and tests worked. So there is a bug there somewhere.

@rotemmiz rotemmiz changed the title Running build-framework-cache after switching Xcode version didn’t work Running build-framework-cache produces different output directory than expected Nov 12, 2017
@rotemmiz
Copy link
Member

Ho man, this was caused since build_framework.ios.sh script took the current project's package.json instead of Detox's

@rotemmiz rotemmiz reopened this Nov 12, 2017
@heuism
Copy link

heuism commented Nov 24, 2017

@rotemmiz, @LeoNatan Sorry to ask but is this one fixed or is there already a walk around approach? I got the same issue running on CircleCI

Thanks

@LeoNatan
Copy link
Contributor Author

It's fixed in the latest version.

@wix wix locked and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants