WIP: Location support #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@silyevsk , we need to investigate why our idling resource doesn't synchronize the async request for location from the app : navigator.geolocation.getCurrentPosition(success.bind(this), error.bind(this)); |
# Conflicts: # detox/test/index.ios.js
silyevsk
force-pushed
the
location-support
branch
from
75033ec
to
32e2f09
Compare
|
navigator.geolocation.getCurrentPosition is an sync function, the expectation in the was checked before there was a return from getCurrentPosition. I've changed the screen/test a bit to wrap it with async/await |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.