Move matchers to generated code #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielMSchmidt
force-pushed
the
chore/generate-matchers
branch
3 times, most recently
from
6b25e3d
to
7e5e467
Compare
This allows us to transform the rest of the matchers and it is a potential solution for other transformations regarding ids as well
DanielMSchmidt
force-pushed
the
chore/generate-matchers
branch
from
7e5e467
to
0d7abb9
Compare
rotemmiz
approved these changes
Oct 4, 2017
DanielMSchmidt
added a commit
that referenced
this pull request
Oct 18, 2017
This reverts commit 9f65786.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the amount of hand written adapter code. The entire matchers file is moved to generated adapter classes, which should enable us to move forward quicker in the future.